Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] Redesign share with list followup #7315

Merged
merged 15 commits into from
Jul 26, 2022
Merged

[full-ci] Redesign share with list followup #7315

merged 15 commits into from
Jul 26, 2022

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Jul 22, 2022 •
edited
Loading

Description

Moved access details button into 3-dot menu

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs
Copy link

update-docs bot commented Jul 22, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Jul 22, 2022 •
edited
Loading

Results for oC10SharingIntUsers1 https://drone.owncloud.com/owncloud/web/27026/30/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUISharingInternalUsers-shareWithUsers_feature-L139.png

webUISharingInternalUsers-shareWithUsers_feature-L139.png

@AlexAndBear AlexAndBear changed the title Redesign share with list followup [full-ci] Redesign share with list followup Jul 22, 2022
@AlexAndBear AlexAndBear force-pushed the redesign-share-with-list-followup branch from 6d774b0 to a2ac150 Compare July 22, 2022 15:27
@AlexAndBear AlexAndBear marked this pull request as ready for review July 22, 2022 16:37
@AlexAndBear AlexAndBear requested a review from kulmann July 22, 2022 16:37
@SwikritiT SwikritiT self-assigned this Jul 25, 2022
@SwikritiT
Copy link
Contributor

@janackermann I will look into the CI failure

kulmann
kulmann approved these changes Jul 25, 2022
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@AlexAndBear
Copy link
Contributor Author

@SwikritiT Do you need something from me to get it done?

@SwikritiT
Copy link
Contributor

SwikritiT commented Jul 26, 2022 •
edited
Loading

@janackermann I found a little buggy behaviour consider following scenario

  1. As user Alice share a resource something.txt with two users or group say Aron and walter
  2. Now remove the share of the top user Aron in this case
  3. Now try to open the access details of user walter
  4. It doesn't open up

The behaviour cannot be reproduced if I remove water first though

simplescreenrecorder-2022-07-26_14.55.14.mp4

@SwikritiT
Copy link
Contributor

@janackermann I found a little buggy behaviour consider following scenario

  1. As user Alice share a resource something.txt with two users or group say Aron and walter
  2. Now remove the share of the top user Aron in this case
  3. Now try to open the access details of user walter
  4. It doesn't open up
    The behaviour cannot be reproduced if I remove water first though

simplescreenrecorder-2022-07-26_14.55.14.mp4

Some of the tests are failing for me locally due to this

@AlexAndBear
Copy link
Contributor Author

@SwikritiT THX will follow up

@AlexAndBear
Copy link
Contributor Author

@SwikritiT
fixed

SwikritiT
SwikritiT suggested changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to find out better solution for this

tests/acceptance/pageObjects/FilesPageElement/SharingDialog/collaboratorsDialog.js Outdated Show resolved Hide resolved
@SwikritiT SwikritiT requested a review from individual-it July 26, 2022 10:47
@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

91.7% 91.7% Coverage
0.0% 0.0% Duplication

SwikritiT
SwikritiT approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green

@AlexAndBear AlexAndBear merged commit 097e750 into master Jul 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the redesign-share-with-list-followup branch July 26, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT approved these changes

@kulmann kulmann kulmann approved these changes

@individual-it individual-it Awaiting requested review from individual-it

Assignees

@SwikritiT SwikritiT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlexAndBear @ownclouders @SwikritiT @individual-it @kulmann